[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3460 Yeah, true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 According to GitHub this wasnt merged yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3460 Looks like the PR wasn't closed as part of the merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've added the documentation for the HistoryServer. It's integrated into the "Monitoring REST API" page since it is so closely related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've finishes writing the remaining tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've addressed your remaining comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've addressed most of your comments. Missing is some javadocs, renaming of the web-ui, bounding the size of the map in the ArchiveFetcher. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've addressed the remaining comments. Still undecided on the handler re-use; tests/documentation still missing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3460: [FLINK-1579] Implement History Server
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3460 @uce I've addressed a few of your comments (all that i gave a Thumbs up) I will implement that we write out only 1 file instead of multiple ones; this removes plenty of edge cases and makes the JobFileFetcher irrelevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---