[GitHub] flink issue #3472: [FLINK-5963] [table] Remove prepare mapper of DataSetAggr...

2017-03-09 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3472
  
Thanks @fhueske. I will rebase this and replace foreach with while loops, 
and merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3472: [FLINK-5963] [table] Remove prepare mapper of DataSetAggr...

2017-03-08 Thread fhueske
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/3472
  
Thanks for the reviews @shaoxuan-wang and @sunjincheng121.
Will merge this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3472: [FLINK-5963] [table] Remove prepare mapper of DataSetAggr...

2017-03-04 Thread fhueske
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/3472
  
Hi @sunjincheng121, thanks for your review. I addressed you comments. 
Cheers, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---