[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 Thanks for reviewing again, @kl0u! I incorporated all your suggestions. I'm now waiting for travis to give the green light and then I'll merge. @chenqin A lot of thanks also to you for working on this and pushing it with me! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 @kl0u @chenqin I cleaned up the commits, distributed the fixes from the comments to the right commits. I also added more tests/ITCases for: detecting name clashes in side output IDs, side outputs with multiple consumers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3484 Thanks @kl0u for the (already) quite thorough review! I'll push a commit with fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink
Github user uce commented on the issue: https://github.com/apache/flink/pull/3484 Unfortunately, I won't have time to look over this PR this week. Thanks for pinging me @aljoscha @chenqin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
