[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Failing test case has just been fixed. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 I think I have to correct myself. In the general case, there might be the need to connect from the dispatcher component to `ResourceManager`. If the `ResourceManager` runs in a different process in standalone mode, then we have to be able to configure a fixed endpoint name, I think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Thanks for the review @StephanEwen. You're right that it should not be necessary to assign a name to the `TaskExecutor` and the `ResourceManager`. Will change it so that these components assign a random name. Will then rebase the PR and once Travis gives green light, I will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3596 Good changes! I think we could actually drop the explicit endpoint name from the `TaskExecutor` and always let it use a random name (as is the default when no explicit name is given). That would simplify the code a bit and it should work since the connection is always established by the `TaskExecutor` towards the `ResourceManager` and `JobManager`, but never the the other way around. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Travis passed. Rebasing on the latest master. If travis passes again, then I will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Rebasing on the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
