[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[zentol]

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3720
  
merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[alpinegizmo]

Github user alpinegizmo commented on the issue:

https://github.com/apache/flink/pull/3720
  
Yes, let's get this done.

On Jun 6, 2017 19:03, "Stephan Ewen"  wrote:

> @alpinegizmo  @zentol
>  Now that #4043
>  is merged, can we rebase this
> one?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3720
  
@alpinegizmo @zentol Now that #4043 is merged, can we rebase this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[alpinegizmo]

Github user alpinegizmo commented on the issue:

https://github.com/apache/flink/pull/3720
  
This looks good, thank you. However, I now understand what was going on 
with the downgrade of the octokit dependency. I think we should first merge 
https://github.com/apache/flink/pull/4043 and then rebase this PR. @zentol 
@StephanEwen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[mtunique]

Github user mtunique commented on the issue:

https://github.com/apache/flink/pull/3720
  
@StephanEwen I think it is the best way to solve this issue. I will follow 
the suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3720
  
@mtunique What do you think about @alpinegizmo 's suggestion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[alpinegizmo]

Github user alpinegizmo commented on the issue:

https://github.com/apache/flink/pull/3720
  
I prefer a conservative approach for as long as we still have to support 
building the docs on Ruby 1.9, so I'd keep the number of updated gems as small 
as possible.

As for adding support for Ruby 2.4, both docs/Gemfile and 
docs/ruby2/Gemfile should be updated, along with their corresponding (and 
derived) Gemfile.lock files. Moreover, the octokit downgrade is not needed. 

I'm not sure what motivates some of the proposed gem upgrades. I was able 
to get the docs to build on ruby 2.4 by making changing both Gemfiles as shown 
below. This leaves the classifier-reborn, ffi, libv8, posix-spawn, rb-inotify, 
redcarpet, and sass gems as they are rather than upgrading them. Do we need 
newer versions of any of those?

-gem 'json'
+gem 'json', '2.0.4'
+gem 'yajl-ruby', '1.2.2'
+gem 'jekyll-coffeescript', '1.0.2'

With these upgrades, the build script still works for me on Ruby 1.9.3 and 
2.3.3, as well as 2.4.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[zentol]

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3720
  
The `GemFile` should be updated as well. It would still work as long as the 
`GemFile.lock` file is present. If it deleted however the bundler would load 
the dependencies from `GemFile` and create a new `GemFile.lock`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3720
  
I am not familiar with the Ruby / Bundler / etc space, but it looks like 
`Gemfile` is the original source of truth and `Gemfile.lock` is in some way 
derived from that.
Is it correct to only update `Gemfile.lock` and not `Gemfile`?

@uce or @alpinegizmo can you maybe shed some light here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[zentol]

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3720
  
I can confirm that you can build the docs on W10 with the Linux Subsystem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[haohui]

Github user haohui commented on the issue:

https://github.com/apache/flink/pull/3720
  
+1 (non-binding)
Tested on OSX Sierra. The documentation builds successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[haohui]

Github user haohui commented on the issue:

https://github.com/apache/flink/pull/3720
  
I hit the same problem on my Mac. Let me try it out later today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[StephanEwen]

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3720
  
Would be great if someone else could confirm that this works. Ideally, we 
get a +1 from a Linux user, a MacOS X user, and a Cygwin user...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---