[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3870 Thanks @rmetzger ! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3870 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3870 Updated and enhanced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3870 @gyfora Yes, this is still a limitation, because the incremental checkpoints are currently not (yet) externalizable. The missing piece is, exactly as you said, familiarizing the `SavepointSerializer` with the new state handle classes from the incremental checkpoints. I will create a jira to track this: https://issues.apache.org/jira/browse/FLINK-6545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3870 Hi, I am sending this because I will be away for the weekend so won't have time to test further until monday. I pulled these changes and Stephan's classloader fix but I still get some errors. (Possible you are working on other fixes, if so just ignore me :)) These logs might help: JM: https://gist.github.com/gyfora/1b54c10601e7482009c6adb804dbcfbf TM: https://gist.github.com/gyfora/ee632bfcd0115a746bc55440bd8815e7 Seems like the SavepointV2Serializer can't handle the Incremental rocks handle because it's not a KeyGroupsStateHandle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3870 CC @shixiaogang @StephanEwen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---