[GitHub] flink issue #3881: FLINK-6284 Incorrect sorting of completed checkpoints in ...
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3881 I won't be available for next 2 to 3 hours. So feel free to decide based on your convenience in case you need to make the RC candidate for 1.3 release. I am sorry that I could not make an initial commit that took care of things properly, should have been more careful. Thanks for the opportunity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3881: FLINK-6284 Incorrect sorting of completed checkpoints in ...
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3881 @tillrohrmann Thanks for the new PR. I just executed your change with 101, 99 , 100 as the checkpoint order. In this case 100 should be the latest one though the actual ids are not sorted. But with your change and my earlier commit it will always sort 99, 100, 101. Can you take a look at my latest commit, that is based on czxid (as per your suggestion) and I think that makes sense. What ever be the actual id, in the zookeeper what was created recently will be the latest checkpoint. But am not very sure if the checkpointId will really be added in a non-sorted way and can 100 be the latest one (though 101 was also there). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3881: FLINK-6284 Incorrect sorting of completed checkpoints in ...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3881 Hi @ramkrish86, I might have found an easy way to solve the problem. Take a look at https://github.com/tillrohrmann/flink/commit/5bd499329d68c6f3236b4e89ba25fdb9acb7e422. If this solves the problem, then I would open a PR with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
