[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-24 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3890
  
@haohui can you close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-16 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3890
  
The Java version of the API also depends on the Scala classes of 
`flink-table`. Everything in `org.apache.flink.table.api` is used in both 
languages. `org.apache.flink.table.api.scala/java` contain language specific 
classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-15 Thread haohui
Github user haohui commented on the issue:

https://github.com/apache/flink/pull/3890
  
My understanding is that the snippet should only depend on the Java version 
of the API (`ROW_NAMED` in flink-core) instead of the one written in Scala that 
resides in `flink-table`. Correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-15 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/3890
  
-1
@haohui The examples are correct if you use Types class of the Table API: 
`org.apache.flink.table.api.Types`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-14 Thread rmetzger
Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/3890
  
Thank you for addressing this so quickly.
+1 from my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---