[GitHub] flink issue #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection of Kafk...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4357 @aljoscha sure, merging this now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection of Kafk...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4357 I reviewed this a last time with Stephan, offline, and we think we should go with this version. Overriding the snapshot methods is most likely not necessary anymore but if it is we will "un-finalize" them again before release. @tzulitai Do you want to have the honours of merging? ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection of Kafk...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4357 I don't but I would like to give @StephanEwen a chance to comment on the changes that make the checkpoint-related methods on the consumer base final. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection of Kafk...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4357 @aljoscha do you have any last comments on these changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection of Kafk...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4357 R: @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
