[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 Already close it ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4509 merged in 268867ce620a2c12879749db2ecb68bbe129cad5 @zhijiangW can you close this PR? ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , the codes are updated. ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 Already submit the codes for the missed comments, @NicoK ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , I divided the original `testRequestAndReturnFloatingBuffer` into three separate tests 'testAvailableBuffersLessThanRequiredBuffers`, `testAvailableBuffersEqualToRequiredBuffers` and `testAvailableBuffersMoreThanRequiredBuffers`. And verifies the following behaviors among them: 1. Recycle the exclusive buffer 2. Recycle the floating buffer 3. Decrease the backlog ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for your reviews on Thanksgiving day. I have updated the codes addressed your comments. : ) ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK, I have submitted the updates addressed all the comments. Wish your continued reviews! :) ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK @pnowojski , this PR is ready now. I rebased the latest master code and updated the modifications based on previous comments. ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , I have fixed the other code issues. For UT, I only added one test for verifying there is no race condition between requesting and recycling floating buffers. I am not sure whether to control the process by `CountDownLatch` is enough. Or I should submit two different threads to execute the process repeated. If this way is ok, I will add more tests for race condition along with `NetworkBufferPool#createBufferPool()` modifications you suggested. For fair distribution of buffers test, I will add one test, maybe in this PR or in #4735 later. ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for reviews and talking about this key point. I think I understand your point and agree with that. I will submit the modifications before Monday. ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , I have submitted the modifications based on your comments. I will add the description for `CreditBasedClientHandler` module as you suggested in next PR, because the description should also cover the function of writing and flushing credit message. ---
[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for your reviews! Actually there are still two PRs under submitted before this PR. One is for floating buffer interaction between `RemoteInputChannel` and `BufferPool`, the other is `onSenderBacklog` logic in `RemoteInputChannel`. I will submit both of them this week and also rebase this PR based on your comments. ---
