[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

2017-08-14 Thread wuchong
Github user wuchong commented on the issue:

https://github.com/apache/flink/pull/4538
  
Thanks for the reminding @zentol . I will pay attention to the commit 
message in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

2017-08-14 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4538
  
@twalthr @wuchong Please make sure that the commit messages describes what 
was changed, and not the state before the change. We now have a commit that 
adds support for quoted strings, with the commit message saying that this isn't 
supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #4538: [FLINK-7441] [table] Double quote string literals is not ...

2017-08-14 Thread twalthr
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/4538
  
Thanks for the PR @wuchong. Very important fix. I will merge it now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---