[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-12-13 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
...rebased onto latest master


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-28 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
test failures are unrelated this time (failing kafka download for the 
end-to-end tests)


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-28 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
sorry about that - tested locally now and it should go through...we'll see


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4581
  
Still failing with some checkstyle violations in `ResultPartition.java`


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-25 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
(arg - I guess I should really fix my default file template some time...)

-> the latest commit fixes the missing license text in the new test file


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-24 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4581
  
Rat check did not pass. Could you please fix this @NicoK.


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-23 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
ok, fixed


---


[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-23 Thread NicoK
Github user NicoK commented on the issue:

https://github.com/apache/flink/pull/4581
  
ok, now I'm using the buffer incorrectly in 
`SpillableSubpartition#add`...let me re-think it once more


---