[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

[yestinchen]

Github user yestinchen commented on the issue:

https://github.com/apache/flink/pull/4673
  
Hi @dawidwys , Thanks for the tip, that's what I tried to add. Sorry for 
the missing times().


---

[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

[dawidwys]

Github user dawidwys commented on the issue:

https://github.com/apache/flink/pull/4673
  
Hi @yestinchen ,
thanks for spotting the mistake. Good catch. However the test you provided 
does not prove the fix. It passes with and without the fix. Please correct it. 
You can e.g. extend the Pattern like this:

Pattern, ?> pattern =
Pattern.>begin("start", 
AfterMatchSkipStrategy.skipPastLastEvent())
.where(new SimpleCondition>() {
@Override
public boolean filter(Tuple2 
rec) throws Exception {
return rec.f1.equals("a");
}
}).times(2);

Then the expected output would be:

expected = "(1,a)\n(3,a)";


---

[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

[yestinchen]

Github user yestinchen commented on the issue:

https://github.com/apache/flink/pull/4673
  
Hi @dawidwys ,
I just found this issue in after match feature, which causes 
AfterMatchSkipStrategy not work. This may be introduced while merging file 
conflicts. I addressed that in this PR and added a simple test to exam such 
problems. Please merge this to the repository. Thanks.


---