[GitHub] flink issue #4801: [FLINK-7812] Log system resources metrics

2017-10-27 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/4801
  
I have made this dependency optional.


---

[GitHub] flink issue #4801: [FLINK-7812] Log system resources metrics

2017-10-13 Thread StephanEwen 
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/4801
  
Eclipse Public License is not impossible, but tricky.

I am not a lawyer, but this is what I picked up over the year: EPL is weak 
copyleft, meaning linking is okay, but modifying not (from Apache License 
compatibility) . Shading the code in the library (which we do when building the 
flink dist jar) is a bit of an gray zone. It does not violate the spirit of the 
license, but a court may see that differently.

Various Flink users that approached us to avoid weak copyleft as much as 
possible because of that uncertainty, so avoiding this dependency would be 
desirable.

Making it an optional dependency that users explicitly have to add is 
possible, because then we do shade it into the Flink distribution jar.


---

[GitHub] flink issue #4801: [FLINK-7812] Log system resources metrics

2017-10-13 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/4801
  
As on dev mailing list discussion, this feature uses 
https://github.com/oshi/oshi library licensed under EPL 1.0. It seems to be 
compatible with ours: https://www.apache.org/legal/resolved.html .

It has minimal external dependencies. Question is whether we want to shade 
everything that we add?

Definitely we could unify config options if we want to do that.


---

[GitHub] flink issue #4801: [FLINK-7812] Log system resources metrics

2017-10-13 Thread StephanEwen 
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/4801
  
Thanks for this addition. Few comments:

  - Please try to follow the common (though not enforced) code style when 
it comes to empty lines between class declarations, fields, methods, etc.

  - What is the license of the new dependency? Can you send a link so we 
can verify that?

  - If possible, let's shade that dependency, avoid increasing the 
dependency footprint.

  - Can we harmonize the config keys between the memory logger and the new 
system metrics?


---