[GitHub] flink issue #4942: [FLINK-7420] [avro] Move all Avro code to flink-avro (fol...

2017-11-03 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4942
  
Great fix for our Avro dependency @StephanEwen, @aljoscha and @twalthr. +1 
for merging.


---

[GitHub] flink issue #4942: [FLINK-7420] [avro] Move all Avro code to flink-avro (fol...

2017-11-03 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4942
  
Personally, I like this Jenkins fellow more... 😉 


---

[GitHub] flink issue #4942: [FLINK-7420] [avro] Move all Avro code to flink-avro (fol...

2017-11-03 Thread StephanEwen 
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/4942
  
Lets see if Travis agrees. That guy has opinions...


---

[GitHub] flink issue #4942: [FLINK-7420] [avro] Move all Avro code to flink-avro (fol...

2017-11-03 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4942
  
The follow-up changes look good! (it's very easy to review since it's 
clearly separated. 😃)

If you reviewed Timo's and my changes I would say this is good to go.


---