[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-15 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5190
  
Great to hear @shuai-xu. Then let's close this PR and open a new JIRA issue 
to separate the bind and advertised REST address for the client.


---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-15 Thread shuai-xu 
Github user shuai-xu commented on the issue:

https://github.com/apache/flink/pull/5190
  
@tillrohrmann , In fact, the original problem I'm concerned with has been 
fix by your commit "[FLINK-8119] [flip6] Wire correct Flip6 components in 
Flip6YarnClusterDescriptor", which set the RestOptions#REST_ADDRESS to the host 
of the container.


---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-14 Thread shuai-xu 
Github user shuai-xu commented on the issue:

https://github.com/apache/flink/pull/5190
  
@tillrohrmann @EronWright , this make it more clear, but seems not solve 
the problem completely. Since we need to set RestOptions#ADDRESS to the address 
of a rest server so the client can access the rest server. But we get 0.0.0.0 
from getRestAddress of the rest server if let the rest server bind to 
RestOptions#BIND_ADDRESS with 0.0.0.0 unless we add another method to the rest 
server which can get the advertised address.


---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-12 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5190
  
I agree with @EronWright. We should introduce an `RestOptions#BIND_ADDRESS` 
which defaults to `0.0.0.0` and a `RestOptions#ADDRESS` which contains the 
advertised address under which the `RestEndpoint` is reachable. What do you 
think @shuai-xu?


---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2017-12-22 Thread EronWright 
Github user EronWright commented on the issue:

https://github.com/apache/flink/pull/5190
  
The configuration option `REST_ADDRESS` seems destined to cause pain.  
Surveying the code, it seems to variously represent a bind address, a server 
address, and an advertised address.   We should rename and clarify ASAP.


---