[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 Merged! ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 Thanks a lot for the review @aljoscha and @tzulitai ! I will wait for travis and then merge. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5230 Ok, now I think it's good to go. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 @aljoscha I addressed your comments. Please have a look. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 @aljoscha and @tzulitai ready for another review. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 @aljoscha @tzulitai I addressed your comments. Let me know what you think about the new version. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5230 Thanks for the comments @tzulitai and @aljoscha ! I already addressed yours @aljoscha and going to @tzulitai 's now. I will ping you as soon as I am done. ---
[GitHub] flink issue #5230: [FLINK-8345] Add iterator of keyed state on broadcast sid...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5230 @tzulitai Very good comments! And we should figure out why the existing migration tests are not failing and adapt them. Oh boy... ð ---
