[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-25 Thread joerg84 
Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/5346
  
@tillrohrmann Could you take a final look?


---

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-24 Thread lishim 
Github user lishim commented on the issue:

https://github.com/apache/flink/pull/5346
  
Thanks @joerg84 for your review and comments.  I have updated the PR to 
address your concerns.


---

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-23 Thread EronWright 
Github user EronWright commented on the issue:

https://github.com/apache/flink/pull/5346
  
+1


---

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-23 Thread joerg84 
Github user joerg84 commented on the issue:

https://github.com/apache/flink/pull/5346
  
Looks great! I need to test that tomorrow in more detail. 
@tillrohrmann @EronWright 


---