[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-26 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5544
  
merging.


---

[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-21 Thread StephanEwen 
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5544
  
Looks good to me.

Would be nice to have another opinion on the config key names. After all, I 
just suggested my personal opinion...


---

[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-21 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5544
  
I've changed the keys to "default" and "additional" and also renamed the 
`ConfigOptions` to `ALWAYS_PARENT_FIRST_LOADER_PATTERNS[_ADDITIONAL]`.


---

[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-21 Thread StephanEwen 
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5544
  
Good change in principle, but I think "base" and "append" are not a great 
choice of names for the parameters. Probably not very intuitive for users.

How about calling them `default` and `additional`?

While at it, should we also rename the `ALWAYS_PARENT_FIRST_LOADER` config 
key name? Calling it `CLASS_LOADING_PARENT_FIRST_PACKAGES` or 
`CL_PARENT_FIRST_PATTERNS` seems better.


---