[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5547 @aljoscha Okay. thanks. I will follow those issues. ---
[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5547 @zhangminglei I suggest you follow those issues and check out the solutions in the end. To be honest, I don't yet know how these difficult tests are going to be ported. ---
[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5547 I see ```verifyResults``` and I found it is too scared for me at this moment. ---
[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5547 Thanks @zentol Yes. I also find this issue is more difficult than what I thought before. I have found those test are really difficult when I keep working on this, as there are many internal API's I must know. Thanks again for telling me and I will leave this issue. ---
[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5547 I would ask you to stop working on this issue. You do not know what changes are required to properly port these tests. Adding a `MiniClusterResource` (or extend `AbstractTestBase`) is unfortunately not enough for the tests that are not covered by #5535 and #5542. The remaining tests are really difficult to port as they *heavily* rely on internal API's. You see all that code in `verifyResults()`? All of that must be rewritten to rely on a (new!) abstraction that works for both legacy and Flip-6 clusters. I appreciate you trying to contribute, but this issue is beyond your capabilities. ---
