[GitHub] flink issue #5558: [FLINK-8747][bugfix] The tag of waiting for floating buff...

2018-02-22 Thread zhijiangW 
Github user zhijiangW commented on the issue:

https://github.com/apache/flink/pull/5558
  
Thanks for your reviews! I already addressed above comments in a separate 
commit.
Regarding the tests I also think the same with you. :)


---

[GitHub] flink issue #5558: [FLINK-8747][bugfix] The tag of waiting for floating buff...

2018-02-22 Thread zhijiangW 
Github user zhijiangW commented on the issue:

https://github.com/apache/flink/pull/5558
  
@NicoK , as I described in the purpose of the change, there are two 
scenarios for this issue. And I only modified the previous 
`RemoteInputChannelTest#testAvailableBuffersLessThanRequiredBuffers` to cover 
one scenario. Do you think it is necessary to cover another scenario by 
recycling exclusive buffers to make available buffers not less than required 
buffers in a new unit test?


---