[GitHub] flink issue #5609: [FLINK-8822] RotateLogFile may not work well when sed ver...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5609 ehh...probably. The PR has a point as `sed --help` (v4.2.2) does not list the `-E` option. If we want to be super safe we could check that `sed -r` is supported and use `-E` as a backup. ---
[GitHub] flink issue #5609: [FLINK-8822] RotateLogFile may not work well when sed ver...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5609 @zentol What do you think? Is this safe to merge? ---
[GitHub] flink issue #5609: [FLINK-8822] RotateLogFile may not work well when sed ver...
Github user BigOneLiu commented on the issue: https://github.com/apache/flink/pull/5609 @zentol thx for comment. I checked my system SUSE 11 SP4(which is a wildly used version),sed version is 4.1.5,and it do not support '-E'. I don't konw how many linux version use sed 4.1.5. According to the source code,'-E' is exactly the same as '-r' and '-E' is Undocumented. So maybe '-r' is more compatible. If don't need to be changed,at least note in the doc that "log may not work well in SUSE 11". ---
[GitHub] flink issue #5609: [FLINK-8822] RotateLogFile may not work well when sed ver...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5609 Not sure about this one, after all `4.2` is already _9 years old_. According to https://stackoverflow.com/questions/3139126/whats-the-difference-between-sed-e-and-sed-e and https://www.gnu.org/software/sed/manual/sed.html it also looks like `-E` is more portable. ---
