[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5613 Merging for now and opening more issue around this topic. ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/5613 @twalthr I'm fine with this PR. Best ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5613 @Xpray and @hequn8128 are you fine with merging this PR for now and then open follow-up issues for more splitting (unboxing, expression, class)? ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/5613 @twalthr yes that your PR have solved the urgent ones. I have cases with huge unboxing code but we can still split it in this way. As for large section codes of one field we may have to make the local variables to member field and split, we might finally use sub classes to avoid JVM's limitation. ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5613 Hi @twalthr Current implementation will reach the limits if a field becomes too large. This can be reproduced by creating a filed produced by concat_ws(). see https://github.com/hequn8128/flink/commit/871fb2c7723c11dd0b75176a3be3be70e2740b2b Best, Hequn ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5613 @Xpray yes that might be necessary as well. I think this code does not solve all problems but the most urgent ones. It still fails if expressions in a field become too large or the unboxing. Or even the class itself. There are many limitation that could be reached: https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.9 Do you have use cases where you reach the limits with my current implementation? ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/5613 It looks great, how about splitting reuseInputUnboxCode as well? I found UnboxingCode might be oversized and has to split. ---
[GitHub] flink issue #5613: [FLINK-8274] [table] Split generated methods for preventi...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5613 @Xpray what do you think about this approach? ---
