[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...

2018-03-22 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5744
  
hi @tillrohrmann  you mean change to `stay()`? I have changed to this 
style. It seems that in scala FSM  we could not do nothing, it should return 
task monitor's state.


---


[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...

2018-03-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5744
  
Thanks for the contribution @yanghua. I fear that the `TASK_KILLING` states 
have been left out deliberately. When a task is being killed, then you don't 
stop. Thus, the issue is actually a non issue. What we could do is to make the 
match exhaustive to add a `TASK_KILLING => noOp`.


---


[GitHub] flink issue #5744: [FLINK-8931] TASK_KILLING is not covered by match in Task...

2018-03-21 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5744
  
cc @tillrohrmann 


---