[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

2018-04-18 Thread bowenli86 
Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/5864
  
+1


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

2018-04-18 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5864
  
merging.


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

2018-04-18 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/5864
  
Thanks @zentol 👍 


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

2018-04-18 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/5864
  
Hi, @bowenli86 No. It wont gives warning logging, instead it will gives 
static compilation warning.


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

2018-04-18 Thread bowenli86 
Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/5864
  
does using Collections.EMPTY_MAP/EMPTY_SET lead to some warnings logging? 


---