[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-29 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/6081
  
Thanks for the contribution! Merged.


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-14 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/6081
  
👍 Yes, I have already approved it on github:
> pnowojski approved these changes 23 hours ago


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-14 Thread yanghua 
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6081
  
cc @pnowojski does this PR look good to you?


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-13 Thread yanghua 
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6081
  
@pnowojski  test error has fixed~


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-13 Thread yanghua 
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6081
  
cc @pnowojski please review this, thanks~


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-11 Thread pnowojski 
Github user pnowojski commented on the issue:

https://github.com/apache/flink/pull/6081
  
@yanghua why is it difficult? Can not you create more or less similar test 
to @GJL's `testSetsUserCodeClassLoader` from here: 
https://github.com/apache/flink/pull/4980/files. With couple side notes:

1. build `MockEnvironment` using `MockEnvironmentBuilder` with a custom 
user class loader - do not use mockito for that
2. create a stream task (reusing one of the implementation in 
`StreamTaskTest.java` or create a new one)
3. register a timer service, wait for it's triggering and assert the user 
class loader in `ProcessingTimeCallback#onProcessingTime`


---

[GitHub] flink issue #6081: [FLINK-8067] User code ClassLoader not set before calling...

2018-06-07 Thread yanghua 
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6081
  
@pnowojski I've tried but it seams it's hard to do this. The class loader 
can not be accessed out of the class. @GJL any suggestion? Or need to test?


---