[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 OK, yes, this PR really make the binary package size more bigger. Closing this issue... ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6123 I'm with Till here. The example JARs add very little value. I would be OK with adding them if this was lightweight, but each example will include the Table API and its dependencies (incl. Calcite and Janino) and hence be 16MB in size. So adding these examples to the distribution adds 80MB in total for very little value. Hence, I would not add them to the distribution. ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 hi @tillrohrmann I think we should include the table example jar into Flink's binary distribution just like `batch`, `streaming`, `gelly`, `python` examples for those people who do not want to try SQL Client. It can make the `examples` dir keeps completeness. Maybe it's an omission before. ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6123 Thanks for opening the PR @yanghua. I would need some input from @twalthr or @fhueske whether it already makes sense to include the Flink table example programs in Flink's binary distribution. I'm not entirely sure whether adding table API example programs would add much additional value since in the end it is just another jar which you can submit. I think the sql cli with which you can run SQL statements would serve this purpose better. ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @dawidwys can you review this? ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @fhueske can you review this PR? ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 @twalthr can you have a look? ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @twalthr ---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6123 Please provide a reasoning when opening JIRAs, i.e. the answer to "Why should we make this change?". ---
