Github user snuyanzin commented on the issue:

    https://github.com/apache/flink/pull/6223
  
    @fhueske @hequn8128 @yanghua thank you very much for your review and 
comments
    I did almost all the corrections except one related to atan2 description
    So I have a question:
    as @hequn8128 wrote
    > I checked the [wiki](https://en.wikipedia.org/wiki/Atan2) about atan2, it 
said: The atan2 function calculates one unique arc tangent value from two 
variables y and x. So, would it be better of two variables? atan2(y,x) can be 
the arc tangent of (x,y) or (nx, ny).
    
    At the same time I checked [Calcite's 
definition](https://calcite.apache.org/docs/reference.html) of it: 
_ATAN2(numeric, numeric) | Returns the arc tangent of the numeric coordinates._ 
    What do you think what is more suitable?


---

Reply via email to