[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-25 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6378
  
merging.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-23 Thread YCjia
Github user YCjia commented on the issue:

https://github.com/apache/flink/pull/6378
  
 @greghogan  Thanks for your reminder. Since version 20 was released on 
July 7, 2018, I think it is more appropriate to use version 20. I have modified 
the code I submitted. I am a newbie here, please point out my mistake.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-22 Thread YCjia
Github user YCjia commented on the issue:

https://github.com/apache/flink/pull/6378
  
@zentol  Thank you for your reminder, I will pay attention in the future.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-22 Thread zentol
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6378
  
@zhangminglei @YCjia Please do not push changes for the sole purpose of 
re-triggering Travis. We already know that they passed (due to the travis 
fork), and realistically there's no way for the parent pom to influence this 
test.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-21 Thread zhangminglei
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/6378
  
Could you please push code and trigger the travis again ? 


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread YCjia
Github user YCjia commented on the issue:

https://github.com/apache/flink/pull/6378
  
@TisonShadowsong @zhangminglei  I ran these tests locally, but they all 
succeeded, and the Travis CI build for my fork repository passed too.  
https://travis-ci.com/YCjia/flink/builds


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread zhangminglei
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/6378
  
@TisonShadowsong is right. You can verify that and i think it might be a 
bug.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread TisonShadowsong
Github user TisonShadowsong commented on the issue:

https://github.com/apache/flink/pull/6378
  
The test that fails is `WindowCheckpointingITCase`, not sure but @YCjia you 
can run it locally to figure out what happened.


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread tedyu
Github user tedyu commented on the issue:

https://github.com/apache/flink/pull/6378
  
No particular reason - considering the date when JIRA was first logged :-)


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread greghogan
Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/6378
  
Any reason not to use version 20 or are we just being conservative?


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread tedyu
Github user tedyu commented on the issue:

https://github.com/apache/flink/pull/6378
  
lgtm

Pending QA bot


---


[GitHub] flink issue #6378: [FLINK-9236] [pom] upgrade the version of apache parent p...

2018-07-20 Thread zhangminglei
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/6378
  
@YCjia The travis test failed. Could you take a look on what is happening ?


---