[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/189#issuecomment-88910737 Fix for the build failure is being tested: https://travis-ci.org/rmetzger/flink/builds/56885481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/189#issuecomment-78025522
The documentation is very well written.
I've tried the pull request on a Hortonworks Sandbox with HDP 2.2.
They have Tez 0.5.2.2.2.0.0 installed there. The mvn command to build Tez
for this environment is:
```
mvn install -DskipTests -Pinclude-tez -Dhadoop.version=2.6.0
-Dtez.version=0.5.2.2.2.0.0-2041 -Pvendor-repos
```
To change the tez version, I made the following changes to the pom:
```diff
diff --git a/flink-staging/flink-tez/pom.xml
b/flink-staging/flink-tez/pom.xml
index e84f731..147dd32 100644
--- a/flink-staging/flink-tez/pom.xml
+++ b/flink-staging/flink-tez/pom.xml
@@ -34,6 +34,9 @@ under the License.
nameflink-tez/name
packagingjar/packaging
+properties
+ tez.version0.6.0/tez.version
+/properties
dependencies
dependency
@@ -81,25 +84,25 @@ under the License.
dependency
groupIdorg.apache.tez/groupId
artifactIdtez-api/artifactId
-version0.6.0/version
+version${tez.version}/version
/dependency
dependency
groupIdorg.apache.tez/groupId
artifactIdtez-common/artifactId
-version0.6.0/version
+version${tez.version}/version
/dependency
dependency
groupIdorg.apache.tez/groupId
artifactIdtez-dag/artifactId
-version0.6.0/version
+version${tez.version}/version
/dependency
dependency
groupIdorg.apache.tez/groupId
artifactIdtez-runtime-library/artifactId
-version0.6.0/version
+version${tez.version}/version
/dependency
dependency
```
Once these issues have been resolved, I'd say the change is +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/189#issuecomment-76407035 I tested this on a 25-node cluster with WordCount and the modified TPC-H query on generated TPC-H data of scale 1000. I also added docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/189#discussion_r25512682
--- Diff:
flink-staging/flink-tez/src/main/java/org/apache/flink/tez/client/RemoteTezEnvironment.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tez.client;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.flink.api.common.JobExecutionResult;
+import org.apache.flink.api.common.Plan;
+import org.apache.flink.api.java.ExecutionEnvironment;
+import org.apache.flink.compiler.DataStatistics;
+import org.apache.flink.compiler.PactCompiler;
+import org.apache.flink.compiler.costs.DefaultCostEstimator;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.util.ClassUtil;
+import org.apache.hadoop.util.ToolRunner;
+
+
+public class RemoteTezEnvironment extends ExecutionEnvironment {
+
+ private static final Log LOG = LogFactory.getLog(TezExecutor.class);
+
+ private PactCompiler compiler;
+ private TezExecutor executor;
+ private Path jarPath = null;
+
+
+ public void registerMainClass (Class mainClass) {
+ jarPath = new Path(ClassUtil.findContainingJar(mainClass));
+ //this.jarURL =
mainClass.getProtectionDomain().getCodeSource().getLocation();
--- End diff --
this looks like debugging code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/189#discussion_r25512719
--- Diff:
flink-staging/flink-tez/src/main/java/org/apache/flink/tez/client/RemoteTezEnvironment.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tez.client;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.flink.api.common.JobExecutionResult;
+import org.apache.flink.api.common.Plan;
+import org.apache.flink.api.java.ExecutionEnvironment;
+import org.apache.flink.compiler.DataStatistics;
+import org.apache.flink.compiler.PactCompiler;
+import org.apache.flink.compiler.costs.DefaultCostEstimator;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.util.ClassUtil;
+import org.apache.hadoop.util.ToolRunner;
+
+
+public class RemoteTezEnvironment extends ExecutionEnvironment {
+
+ private static final Log LOG = LogFactory.getLog(TezExecutor.class);
--- End diff --
The log messages will appear from the wrong class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
