[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user akshaydixi closed the pull request at: https://github.com/apache/flink/pull/508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user akshaydixi commented on the pull request: https://github.com/apache/flink/pull/508#issuecomment-92691766 Ok. So should I delete this branch then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/508#issuecomment-93084344 yes please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/508#issuecomment-92455713 Hey Sorry I made a major refactoring today, and I also did the renaming with much shorter names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/508#issuecomment-84592099 I personally don't like the sound of all these class names too much. It seems to be too redundant and too long in most cases. I know the ...Invokables weren't so much better either but at least they were short. Let us think about this for a little before making these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/508#issuecomment-84576440 Nice, thanks for also updating the minor details. `GroupedWindowBufferStreamOperator` is a bit long of a name for my taste, but other than LGTM. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1655] Renamed StreamInvokable to Stream...
GitHub user akshaydixi opened a pull request: https://github.com/apache/flink/pull/508 [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. Changes made are: * StreamInvokable - StreamOperator * ChainableInvokable - ChainableStreamOperator * SinkInvokable - SinkStreamOperator * SourceInvokable - SourceStreamOperator * CoFlatMapInvokable - CoFlatMapStreamOperator * CoGroupedReduceInvokable - CoGroupedReduceStreamOperator * CoInvokable - CoStreamOperator * CoMapInvokable - CoMapStreamOperator * CoReduceInvokable - CoReduceStreamOperator * CoWindowInvokable - CoWindowStreamOperator * GroupedWindowBufferInvokable - GroupedWindowBufferStreamOperator * WindowBufferInvokable - WindowBufferStreamOperator * CounterInvokable - CounterStreamOperator * FilterInvokable - FilterStreamOperator * FlatMapInvokable - FlatMapStreamOperator * GroupedFoldInvokable - GroupedFoldStreamOperator * GroupedReduceInvokable - GroupedReduceStreamOperator * MapInvokable - MapStreamOperator * ProjectInvokable - ProjectStreamOperator * StreamFoldInvokable - FoldStreamOperator * StreamReduceInvokable - ReduceStreamOperator You can merge this pull request into a Git repository by running: $ git pull https://github.com/akshaydixi/flink FLINK-1655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 18ba6e31b7cd0eb0eac857595ba8ad304d81202a Author: Akshay Dixit akshayd...@gmail.com Date: 2015-03-21T11:28:53Z [FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
