[GitHub] flink pull request: [FLINK-1753] [streaming] Added test for Kafka ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1753] [streaming] Added test for Kafka ...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/557#issuecomment-88794220 I'm merging this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1753] [streaming] Added test for Kafka ...
GitHub user gaborhermann opened a pull request: https://github.com/apache/flink/pull/557 [FLINK-1753] [streaming] Added test for Kafka connector with tuple type Extended the KafkaITCase with a topology of a non-String type and fixed a small bug with Kafka key serializer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaborhermann/flink flink-1753 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #557 commit 8cb784a26efcc7685df5430116854c1ed989b44e Author: Gábor Hermann reckone...@gmail.com Date: 2015-04-01T12:51:04Z [FLINK-1753] [streaming] Added test for Kafka connector with tuple type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1753] [streaming] Added test for Kafka ...
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/557#issuecomment-88523220 Thanks for the remark. I updated the branch and added more tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1753] [streaming] Added test for Kafka ...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/557#issuecomment-88527923 The code looks good. Tests are running locally. As soon as travis signals green, I'm +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
