[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/628 [FLINK-1923] Replaces asynchronous logging with synchronous logging in actors Replaces asynchronous logging with synchronous logging in actors. Additionally, all Scala implementations are now using the grizzled-slf4j SLF4J-wrapper which allows proper usage of SLF4J within Scala code. One problem the grizzled-slf4j wrapper fixes is the ambiguity between varargs and a string with two placeholders. Additionally it resolves the ambiguity between (String, String, Object) where the first String is used as a Marker and where the first string is the logging message. Grizzled-slf4j adds automatically logging guards which make the explicit checking for the log level redundant. Grizzled-slf4j's license is BSD. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixLogging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/628.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #628 commit 34c9fd54448b340505c97679299b8876f0257828 Author: Till Rohrmann trohrm...@apache.org Date: 2015-04-24T14:33:34Z [FLINK-1923] [runtime] Replaces asynchronous logging with synchronous logging using grizzled-slf4j wrapper for Scala. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/628#discussion_r29140183
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -357,16 +356,6 @@ protected void unregisterTask() {
taskManager.tell(new UnregisterTask(executionId),
ActorRef.noSender());
}
- protected void notifyExecutionStateChange(ExecutionState executionState,
--- End diff --
Was this method unused?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/628#issuecomment-96622572 I am curious, why did you rewrite the TaskManager? I thought that one was logging synchronously already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
