[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-133730158 I have created [FLINK-2561](https://issues.apache.org/jira/browse/FLINK-2561) for the sync. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132115823 Looks good to merge except one cosmetic issue. Awesome job! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132118620 I fixed the unneccessary comment and did a quick rebase to keep up with master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132119301 All right, let's merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1004#discussion_r37273914
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.graph.scala
+
+import org.apache.flink.api.common.functions.{FilterFunction, MapFunction}
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.api.java.{tuple = jtuple}
+import org.apache.flink.api.scala._
+import org.apache.flink.graph._
+import org.apache.flink.graph.gsa.{ApplyFunction, GSAConfiguration,
GatherFunction, SumFunction}
+import org.apache.flink.graph.spargel.{MessagingFunction,
VertexCentricConfiguration, VertexUpdateFunction}
+import org.apache.flink.{graph = jg}
+
+import _root_.scala.collection.JavaConverters._
+import _root_.scala.reflect.ClassTag
+
+object Graph {
+ def fromDataSet[K: TypeInformation : ClassTag, VV: TypeInformation :
ClassTag, EV:
+ TypeInformation : ClassTag](vertices: DataSet[Vertex[K, VV]], edges:
DataSet[Edge[K, EV]],
+ env: ExecutionEnvironment): Graph[K, VV, EV]
= {
+wrapGraph(jg.Graph.fromDataSet[K, VV, EV](vertices.javaSet,
edges.javaSet, env.getJavaEnv))
+ }
+
+ def fromCollection[K: TypeInformation : ClassTag, VV: TypeInformation :
ClassTag, EV:
+ TypeInformation : ClassTag](vertices: Seq[Vertex[K, VV]], edges:
Seq[Edge[K, EV]], env:
+ ExecutionEnvironment): Graph[K, VV, EV] = {
+wrapGraph(jg.Graph.fromCollection[K, VV,
EV](vertices.asJavaCollection, edges
+ .asJavaCollection, env.getJavaEnv))
+ }
+}
+
+/**
+ * Represents a graph consisting of {@link Edge edges} and {@link Vertex
vertices}.
+ * @param jgraph the underlying java api Graph.
+ * @tparam K the key type for vertex and edge identifiers
+ * @tparam VV the value type for vertices
+ * @tparam EV the value type for edges
+ * @see org.apache.flink.graph.Edge
+ * @see org.apache.flink.graph.Vertex
+ */
+final class Graph[K: TypeInformation : ClassTag, VV: TypeInformation :
ClassTag, EV:
+TypeInformation : ClassTag](jgraph: jg.Graph[K, VV, EV]) {
+
+ private[flink] def getWrappedGraph = jgraph
+
+
+ private[flink] def clean[F : AnyRef](f: F, checkSerializable: Boolean =
true): F = {
+if (jgraph.getContext.getConfig.isClosureCleanerEnabled) {
+ ClosureCleaner.clean(f, checkSerializable)
+}
+ClosureCleaner.ensureSerializable(f)
+f
+ }
+
+ /**
+ * @return the vertex DataSet.
+ */
+ def getVertices = wrap(jgraph.getVertices)
+
+ /**
+ * @return the edge DataSet.
+ */
+ def getEdges = wrap(jgraph.getEdges)
+
+ /**
+ * @return the vertex DataSet as Tuple2.
+ */
+ def getVerticesAsTuple2(): DataSet[(K, VV)] = {
+wrap(jgraph.getVerticesAsTuple2).map(jtuple = (jtuple.f0, jtuple.f1))
+ }
+
+ /**
+ * @return the edge DataSet as Tuple3.
+ */
+ def getEdgesAsTuple3(): DataSet[(K, K, EV)] = {
+wrap(jgraph.getEdgesAsTuple3).map(jtuple = (jtuple.f0, jtuple.f1,
jtuple.f2))
+ }
+
+ /**
+ * Apply a function to the attribute of each vertex in the graph.
+ *
+ * @param mapper the map function to apply.
+ * @return a new graph
+ */
+ def mapVertices[NV: TypeInformation : ClassTag](mapper:
MapFunction[Vertex[K, VV], NV]):
+ Graph[K, NV, EV] = {
+new Graph[K, NV, EV](jgraph.mapVertices[NV](
+ mapper,
+ createTypeInformation[Vertex[K, NV]]
+))
+ }
+
+ /**
+ * Apply a function to the attribute of each vertex in the graph.
+ *
+ * @param fun the map function to apply.
+ * @return a new graph
+ */
+ def mapVertices[NV: TypeInformation : ClassTag](fun: Vertex[K, VV] =
NV): Graph[K, NV, EV] = {
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1004 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132241841 If the APIs are in sync there should be one documentation for both, right? Similar as with the other APIs... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132235443 What are the plans for documenting the Gelly Scala API ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-132252484 As mentioned, they are not in sync yet. We need to create an issue to update the Scala API so that it is in sync with the Java API. A completeness test should also be added once that is done. Since this API just a wrapper, no additional documentation seems needed but we could add a java/scala tab to the documentation, similar to the Batch API documentation. It would look extremely similar though, so I'm not sure how much added value it would have. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-131148744 Wow, looks like a good piece of work. Nicely with tests and everything. Build also passes, style looks good. +1 to merge this from my side. I'd like to wait for a day or two to get a comment from one of the Gelly people (Vasia or Andra). One thing, though: In the Batch and streaming APIs, we added a completeness check to make sure that methods added to the Java APIs are also present in the Scala APIs. Would that be a good thing to add here as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-131156825 I would postpone adding the completeness check as it will currently fail. Since I started working on this, the Java Gelly API has changed and while I modified my work to be compatible with the changes, not all new Java Gelly methods have a Scala counterpart yet. It was discussed briefly in the initial PR #808 and it was decided that adding these new methods should go into a separate JIRA issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-131169939 +1 from me too. Thanks for your great work @PieterJanVanAeken! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1004#issuecomment-131158707 Sounds good. If no one objects in the next days, I would merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken closed the pull request at: https://github.com/apache/flink/pull/808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API v2
GitHub user PieterJanVanAeken opened a pull request: https://github.com/apache/flink/pull/1004 [FLINK-1962] Add Gelly Scala API v2 Second version of the PR for the Scala Gelly API. For more information, see PR #808 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PieterJanVanAeken/flink scala-gelly Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1004.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1004 commit 64400e89676ffc933f761656260b536665f1d398 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-08-10T12:06:52Z [FLINK-1962] Add Gelly Scala API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-129424059 Opened up a second PR from a cleaned out repo. Closing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128638593 Right @chiwanpark, its the last commit not the PR as a whole. Thanks for clarifying! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128638129 26 files for me as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128638172 [Your last commit](https://github.com/PieterJanVanAeken/flink/commit/463a1f30b3b0785f46c76f9c290da3deec26) includes all updates of master branch. Please remove last commit (`git reset --hard HEAD~1` on your master branch) and rebase your branch on master branch (`git rebase apache/master`) and push to your branch with force update (`git push origin +master`). Additionally, working on non-master branch is better than on master branch. If you work on non-master branch, you can sync your master branch to apache master branch while you are changing your branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128634451 Really? It says 26 files changed for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128681998 I think it's a good idea and it will probably save you time :) Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-128420592 Hi @PieterJanVanAeken! Thanks for the update. It seems something went wrong with your merge. Your last commit shows 1000+ files changed... Could you try to rebase instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-127543254 So I fixed some of the issues and tried to merge with the master branch again. Not sure if I did everything correctly though so if someone could check this again, that would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125117571 @Vasia I have been a bit strapped for time but I should have some time this week to work on this some more. If I am not done by the end of the week, you can always pick up where I left off. So I don't miss anything, what needs to happen now to get this to a mergeable state is add JavaDoc/ScalaDoc, add the Eclipse pom segment, change 4 space tabs to 2 space tabs in Scala and remove some of the unnecessary formatting as a result of auto-format. Did I miss anything? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125112165 Hey @PieterJanVanAeken! Are you back working on this or would you rather someone else takes over? I think I can find some time next week to resolve remaining issues and bring this to mergeable state :) Just let me know! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125120680 Nope, I think that's spot on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125132370 Perfect, thanks @PieterJanVanAeken! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114468380 Hi, Thanks all for the comments. Unfortunately, I will be gone until the 13th of July so I will not be able to resolve these issues until then. They are however all valid points. One more note perhaps, in regard to the unit tests, I added the basic ones (based on the Java version of them), but they are most certainly not all there. The same can be said for the methods that were added recently to the java Gelly API. Since I am a bit strapped for time atm, I was hoping to push this into the official Flink repo (maybe not master branch?) so other people could more easily contribute and help resolve these final issues thus speeding up the process a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114426618 Oh, one more thing :) In order to make this work in Eclipse, I had to add a few lines to the pom.xml. Basically, I copied the `build` block from the streaming-scala project. I'm not sure whether everything in there is needed, so if someone knows better, please let us know ;) Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114412170 ExecutionEnvironment.scala, UnionOperator.java and Graph.java have a lot of whitespace/formatting changes. This makes it hard to see the actual changes to functionality. None of the methods in the new Scala code have comments/Scaladoc. Especially the methods on Graph.scala, these should have documentation, similar to the methods on Graph.java. Other than that, this looks good. I especially like that basically half of the new files are test cases. :+1: Could someone from the Graph side ( @vasia, @andralungu ) please chime in on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114420568 Thanks @aljoscha for reminding me... This slipped my mind for a sec. I agree that the methods should have Scaladoc (this should be straightforward to add starting from the existing Javadoc). What would also be nice, IMO would be to update the docs so that they would also contain a Scala version of the example code snippets, similar to the programming guide, for example (http://ci.apache.org/projects/flink/flink-docs-release-0.8/programming_guide.html). Furthermore, the newly added methods (e.g. `addVertices`) are missing. However, that should be a separate Jira. Apart from the formatting issue and the documentation issue, everything looks nice and clean :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-113150313 Yes, the formatting would indeed have to be changed to conform to the pre-existing Flink Scala style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-113147981 Hi. I'm very excited about Gelly's Scala API. I'm reading the changes from this PR. I found a problem about re-formatting. Unlike Flink's Java code, Flink's Scala code use 2 spaces as indent. But I think the IDE did re-format all code to use 4 spaces as indent. We should preserve the previous indent setting to preserve modification history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-110664776 I will thoroughly check it once the release that is currently happening is done. Then people can check it out and it will have had some expose before releasing it in 0.10. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-110448745 I am super excited about this one! :) Will also have a look in the next days! Awesome job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
GitHub user PieterJanVanAeken opened a pull request: https://github.com/apache/flink/pull/808 [FLINK-1962] Add Gelly Scala API Pull request for adding the Gelly Scala API. There were some issues with rebasing due to both the Java Gelly API and the Testing API changing, so if someone could verify that no changes were lost in the process that would be great. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PieterJanVanAeken/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/808.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #808 commit 6e9bf85832589320500c10bfe3e106d45e2e9211 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T09:47:02Z working MapVertices in Scala API commit 31c723cc0cc81151ad4442151c9308413a8dcd74 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:12:13Z working mapEdges in Scala API commit 1ed23215de06db594c913b83052b8834a9bb3946 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:37:42Z Added the most basic unit test case for MapVertices and MapEdges commit 8f127d019277830b6892a0949647a962a46ea2aa Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:55:59Z Added the most basic unit test case for syntactic sugar versions of MapVertices and MapEdges commit f17b073c4c38f669bc9547b607741f3855955fb7 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T14:53:09Z Added JoinWithVertices plus basic unit test commit 1ae5a7a09fcc63df9452bf61eab6cdbf49a26c44 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T15:12:06Z Removed return clause because redundant commit d410fbc826b29200bec8d1df085f9734f4640794 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T15:32:56Z Added apache license header commit 6f099b4ee9e89f9774158b0419cb1ba5d9ab7191 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T15:36:41Z Added apache license header commit 41690b9e2788672dc8ee26d731c05320caea513a Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-01T08:19:39Z added joinWithEdges on both keys, source and target with basic unit tests commit e5f392a5b4164064ef726f17a310e3098f5be490 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-01T09:02:01Z Added subgraph/filtering and degrees methods plus basic unit test commit 3246a32475865a1d30c27725572248dc67e856eb Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-01T15:37:54Z Added groupReduceOnEdges with vertex value. Required explicit type information declaration in Java API commit 22ae6bdc450c7eb582caba408cf11d8d85821e34 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-01T16:00:36Z Added groupReduceOnEdges without vertex value. Required explicit type information declaration in Java API commit 5ef3090821f13239e1473ae4cf4af8cef77c2ae8 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-03T10:12:40Z Ported bunch of new features to the scala gelly API commit 5dac3761a4f92a8ced388bcdccc93ff0260ce7e5 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-03T14:05:37Z Added vertex centric iterations commit db7301ea3e8a6e890dbdbad5c584d4923cca177a Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-04T14:44:47Z Added GSA iteration. commit 137ef07c9907e2f991dfd2f80dd58cd0555e7ad3 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-04T15:34:32Z Added license headers commit ac2217fb8738f2f8ef4bcbd80bf13b4159ede36d Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-04T15:52:17Z Set line wrapping to 100 chars for Scala commit d9bae248cf86eff3e76ca4647801be79f6868821 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-06-09T09:16:59Z Removed star imports and leading spaces commit 8fb7761146979b488bc6b7c3de0b3f2709adfc8b Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T09:47:02Z working MapVertices in Scala API commit 0b7ff730d29682d026410a8c344dcddbc658208c Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:12:13Z working mapEdges in Scala API commit 2b1f6ea0da82ce0eec338d213de3ffb31133a3b0 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:37:42Z Added the most basic unit test case for MapVertices and MapEdges commit fae6a4124fc4aab22e48c10778bf9697a8b62499 Author: Pieter-Jan Van Aeken pieterjan.vanae...@euranova.eu Date: 2015-05-26T13:55:59Z Added the most
