[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112940323 Perfect, thanks @andralungu! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112373119 PR updated to test the same issue in ApplyCoGroupFunctionOnAllEdges and ApplyCoGroupFunction. Also added tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111993642 @andralungu, I believe the same issue appears in `ApplyCoGroupFunctionOnAllEdges` and `ApplyCoGroupFunction`. Could you check if that's the case and fix those too if needed? Also, adding a test might be a good idea :) Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111761198 Yup, exactly! The use case was: I modified something in the edge data set, called groupReduceOnNeighbors on the result and got NPE, exception that could have been avoided with this check, just like was the case for the Degree NPE. Making sure that the iterator is not null can save some people lots of headaches, IMO :) And it doesn't hurt anyone who has a correct data set. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111760267 Hey @andralungu, I'm not sure I understand this one. It's a coGroup of vertices with the edges. For the vertex iterator to be empty, doesn't it mean that there's an edge with an invalid id? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-110481761 uhmm, guys! IMO this should be merged before the release! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/799 [FLINK-2178][gelly] Fixed groupReduceOnNeighbors bug This PR adds an iterator.hasNext() check in the groupReduceOnNeighbors method, fixing the NoSuchElementException bug reported in FLINK-2178. @vasia , @StephanEwen, maybe we can merge this before the upcoming 0.9 release :) Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink groupReduceOnBug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #799 commit 1655b603016ff9d88eaaecee3b3bd4841d440ce0 Author: andralungu lungu.an...@gmail.com Date: 2015-06-06T11:02:16Z [FLINK-2178][gelly] Fixed groupReduceOnNeighbors bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
