[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gaborhermann closed the pull request at: https://github.com/apache/flink/pull/802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-15823 I think this has been merged manually by @gyfora. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-120875478 Okay, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-120276079 I am currently preparing a new PR with a rework of how the iterations are constructed in the StreamGraph it will be ready today. It will solve many issues that we currently have and will make the iterations much more robust. I am also adding a bunch of new tests. I think this is still a good addition because some of my tests will depend on the maxWaitTime. I propose to add your changes afterwards. I volunteer to port your commits to my changes :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-119321451 The main purpose of this is to enable a deterministic (non-time based) test for iteration as it sometimes failed for some reason on Travis. (See [here] (https://issues.apache.org/jira/browse/FLINK-2180?focusedCommentId=14576968page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14576968)). I thought it might also be useful to users for debugging purposes (similarly to maxWaitTime) and it was also easier to introduce it in the API level. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-114525454 Thanks for the heads up, I removed the aggregation test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/802#issuecomment-112968975 I updated the PR. Added the fix for the iteration test. Probably not getting a new element within the maximum wait time caused the failing of the iteration tests. After this fix it should not be a problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
