[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-129378149 I changed the streaming test to reuse the batch test's logic. Should be good to go know. Merging later on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-129404408 Did you figure out the reason for the NPE, that prevented me from merging this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-129460830 Yes, exactly :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/926 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-129420540 :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-129414456 Yes, it was a race condition that occurred only with the previous streaming test design. The synchronization wouldn't always ensure that the SourceTask had been brought up. Thus we would fail to see any accumulator results for this task. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-127987952 After rebasing to the current master, I had to adapt this PR due to the changes by commit [45428518d0e1b843947a6184b4a803a78ad5](https://github.com/apache/flink/commit/45428518d0e1b843947a6184b4a803a78ad5) (replacing ActorRef jobManager by a ActorGateway). I couldn't merge this PR because one of the Travis builds failed with a NPE in this test: https://travis-ci.org/fhueske/flink/jobs/74219782 This should be investigated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-128002553 Alright, then let me also rebase and investigate the error. It might be some regression due to rebasing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-128003980 Btw. it was just one build that failed with the NPE. The other builds passed (except for one with an unrelated issue). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-127920530 LGTM, will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-125902465 How does this PR relate to the recent improvements on the stability of the live accumulator tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/926#issuecomment-125955678 Sorry for the plain description. This pull request adds a test for the streaming part of the live accumulators, i.e. it makes sure that user-defined and Flink internal accumulators work also in streaming programs. The current test only tests the batch side. The stability of the live accumulator tests should not be affected by this pull request. It uses the same technique as the current (improved) live accumulator tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/926 [FLINK-2387] add streaming test case for live accumulators You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink live-accumulators-streaming Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/926.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #926 commit e0668dc4a5e1bf23085c40d7abae4c8414c29707 Author: Maximilian Michels m...@apache.org Date: 2015-07-21T14:54:26Z [FLINK-2387] add streaming test case for live accumulators --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
