[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-132118469 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-132097606 Good idea @StephanEwen, I'll make the log statements more prominent and then I'll merge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-131829785 Very useful change. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1015 [FLINK-2521] [tests] Adds automatic test name and reason of failure logging Adds TestLogger class which automatically logs the currently executed test names and the reasons for a failure. The automatic logging is achieved by specifying a JUnit Rule which executes a `TestWatcher` for every executed test. This PR makes all test bases extend the TestLogger. For future tests which don't extend a test base, the test class should extend the TestLogger class to add automatic test name logging. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink testLogger Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1015.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1015 commit 6e27752dec68094c1f7498bebc2edd842f064daf Author: Till Rohrmann trohrm...@apache.org Date: 2015-08-14T13:06:06Z [FLINK-2521] [tests] Adds TestLogger class which automatically logs the currently executed test names and the reasons for a failure. Makes test bases extend TestLogger to add automatic test name logging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2521] [tests] Adds automatic test name ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1015#issuecomment-131248356 Looks very nice! I would actually make the log statements about start and stop more prominent (for example frame them with an ascii ruler) to make them visually easier locateable in the log file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
