[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132172991 @StephanEwen Thank you! Do you mean that this PR would not be closed and I can push future checks in this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132138231 The change in the execution class is good. I'll leave the other check in, as it is a good sanity check against future mistakes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132196596 I'll merge half of this pull request... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132205784 Ha... Sorry for my English, just misunderstood the execution. I will learn more about the Thread class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1022#issuecomment-132234428 That is fine, no worries! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2529][runtime]remove some unused code
GitHub user HuangWHWHW opened a pull request: https://github.com/apache/flink/pull/1022 [FLINK-2529][runtime]remove some unused code There are some reviews: 1.var consumerGraph is never used in public Boolean call() throws Exception. 2.In my learned knowledge, function Thread.currentThread() will never return null.So the code shutdownHook != null is unwanted. And i`m not complete sure.Maybe I`m wrong. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HuangWHWHW/flink FLINK-2529 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1022.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1022 commit f630fe9cf28ac734a472134d907e635693f00ad0 Author: HuangWHWHW 404823...@qq.com Date: 2015-08-16T03:56:18Z [FLINK-2529][runtime]remove some unused code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
