[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[willmiao]

Github user willmiao commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-151092573
  
hi @rmetzger ,
I believe I find the reason why my test failed.
A test will fail if we don’t specify “-t” argument(_which is an 
optional argument_) in the command when call runWithArgs function, and we will 
get exception here:
```
Exception in thread "main" java.lang.NoClassDefFoundError: 
org/apache/log4j/Level
at org.apache.hadoop.mapred.JobConf.(JobConf.java:357)
```
It seems some jar files relevant to log callback are needed.

One more thing, I noticed a segment of code as follows in the file 
“FlinkYarnSessionCli.java”:
```
File logback = new File(confDirPath + File.pathSeparator + 
CONFIG_FILE_LOGBACK_NAME);
if (logback.exists()) {
shipFiles.add(logback);
flinkYarnClient.setFlinkLoggingConfigurationPath(new 
Path(logback.toURI()));
}
```
And I wonder if “**File.pathSeparator**” should be 
“**File.separator**” here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[willmiao]

Github user willmiao commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-150919886
  
Hi rmetzger,
I have updated this PR.
I generated a flink-conf.yaml in a directory, which I then used as the 
configuration directory for the test. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[willmiao]

Github user willmiao commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-150928188
  
Sorry for the failed tests, I'll fix them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-147009266
  
That's indeed a good question. I don't have much time currently, but I'm 
trying to answer you within the next few days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[willmiao]

Github user willmiao commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-146371570
  
@rmetzger : I'm sorry for the late reply, I have been on vacation last 
three weeks.
I failed to find a nice way to "generate a flink-conf.yaml just for the 
test", could you please give some tips on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-144765643
  
@willmiao: What is the status of this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-141016403
  
Sorry for the late response, I didn't see this new pull request.

The failed test is okay. The test is known for being unstable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1121#issuecomment-141019208
  
For others who follow this PR, there was already some discussion on this 
change here: https://github.com/apache/flink/pull/1107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1121#discussion_r39725184
  
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -130,6 +130,15 @@ state.backend: jobmanager
 
 
 
#==
+# YARN

+#==
+
+# Default number of YARN container to allocate (=Number of Task Managers)
+
+yarn.defaultNumberOfTaskManagers: 1
--- End diff --

Can you remove the configuration value from the default configuration again?

I would like to force new users to specify the number of yarn containers 
when they start Flink on YARN.
The configuration value is meant for production users which want to control 
everything using configuration values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[rmetzger]

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1121#discussion_r39725238
  
--- Diff: 
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java 
---
@@ -111,6 +111,20 @@ public void testClientStartup() {
}
 
/**
+* Test configuration parameter for default number of yarn containers
+*/
+   @Test
+   public void testDefaultNumberOfTaskManagers() {
+   LOG.info("Starting testDefaultNumberOfTaskManagers()");
--- End diff --

I would generate a flink-conf.yaml just for this test to test the behavior


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

[willmiao]

GitHub user willmiao opened a pull request:

https://github.com/apache/flink/pull/1121

[FLINK-2591] Add configuration parameter for default number of yarn 
containers



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/willmiao/flink FLINK-2591

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1121


commit 6c6005d6ea92177b4a99183f2509a480718dabb2
Author: Will Miao 
Date:   2015-09-10T23:34:35Z

[FLINK-2591]Add configuration parameter for default number of yarn 
containers

commit 154e486620469ffadb9fa9caed0f27f69fbe04ad
Author: Will Miao 
Date:   2015-09-11T12:09:09Z

[FLINK-2591] Add configuration parameter for default number of yarn 
containers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---