[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1209


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1209#issuecomment-145462685
  
@twalthr Please go ahead and merge it. :smile: Then we can close the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[twalthr]

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/1209

[FLINK-2642] [table] Scala Table API crashes when executing word count 
example

This PR improves the checking of the types during table translation. The 
error message for [FLINK-2642] is now correct.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink TableApiWCFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1209


commit 75b2a111729e5a97573e86b64bacf9496bde8a4c
Author: twalthr 
Date:   2015-10-02T09:12:01Z

[FLINK-2642] [table] Scala Table API crashes when executing word count 
example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1209#issuecomment-144979578
  
looks good +1 :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/flink/pull/1209#discussion_r41051842
  
--- Diff: 
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/plan/PlanTranslator.scala
 ---
@@ -110,7 +110,8 @@ abstract class PlanTranslator {
 }
 
 val clazz = repr.getType().getTypeClass
-if (clazz.isMemberClass && !Modifier.isStatic(clazz.getModifiers)) {
+if ((clazz.isMemberClass && !Modifier.isStatic(clazz.getModifiers))
+|| clazz.getCanonicalName() == null) {
--- End diff --

Gah, another Java problem of returning null =(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2642] [table] Scala Table API crashes w...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/1209#issuecomment-145115050
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---