[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[rmetzger]

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1117#discussion_r39251890
  
--- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
 ---
@@ -356,29 +357,24 @@ public void run() {
// make sure that all partitions have some 
offsets to start with
// those partitions that do not have an offset 
from a checkpoint need to get
// their start offset from ZooKeeper
-   
-   List partitionsToGetOffsetsFor 
= new ArrayList<>();
+   {
--- End diff --

I'm opening a new scope for the `partitionsToGetOffsetsFor` variable.
I'm using another list with the same name later in the code. WIth a new 
scope for the operation here, I can use the same variable name later again.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139491178
  
Sorry Henry. I've updated the description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[fhueske]

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139529822
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139529893
  
Thank you for the review. I'll merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[rmetzger]

GitHub user rmetzger opened a pull request:

https://github.com/apache/flink/pull/1117

[FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmetzger/flink flink2656

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1117


commit 582d265e7ac068ff74a107e2bdcfbce87828c810
Author: Robert Metzger 
Date:   2015-09-10T16:47:45Z

[FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/flink/pull/1117#discussion_r39193575
  
--- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
 ---
@@ -356,29 +357,24 @@ public void run() {
// make sure that all partitions have some 
offsets to start with
// those partitions that do not have an offset 
from a checkpoint need to get
// their start offset from ZooKeeper
-   
-   List partitionsToGetOffsetsFor 
= new ArrayList<>();
+   {
--- End diff --

Just curious what is the extra "{" for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2656] Fix behavior of FlinkKafkaConsume...

[hsaputra]

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139331689
  
Hi @rmetzger, could you tell bit summary what the fix should do in the 
description of this PR? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---