[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-164177222 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-163194318 All right, lets merge this then... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-163200275 Olrite. Great! #1418 should also be meregable with this one IMO. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r47076123
--- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade ---
@@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main
.navbar-title
| Overview
+ .navbar-info.last.first
+| Version: {{overview['flink-version']}}
+
+ .navbar-info.last.first(ng-if="overview['flink-commit']")
+| Commit: {{overview['flink-commit']}}
--- End diff --
It will not be displayed at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r47073802
--- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade ---
@@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main
.navbar-title
| Overview
+ .navbar-info.last.first
+| Version: {{overview['flink-version']}}
+
+ .navbar-info.last.first(ng-if="overview['flink-commit']")
+| Commit: {{overview['flink-commit']}}
--- End diff --
Will this print "unknown" as commit ID (because the JSON field is not
present) or will it be skipped?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-162556656 @rmetzger this should be mergeable now. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46774718
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public String handleRequest(Map params,
ActorGateway jobManager)
gen.writeNumberField("jobs-finished",
overview.getNumJobsFinished());
gen.writeNumberField("jobs-cancelled",
overview.getNumJobsCancelled());
gen.writeNumberField("jobs-failed",
overview.getNumJobsFailed());
+ gen.writeStringField("flink-version", version);
+ if (commitID != null) {
--- End diff --
Gah. Apologies. I should've been more careful. Fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46773662
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public String handleRequest(Map params,
ActorGateway jobManager)
gen.writeNumberField("jobs-finished",
overview.getNumJobsFinished());
gen.writeNumberField("jobs-cancelled",
overview.getNumJobsCancelled());
gen.writeNumberField("jobs-failed",
overview.getNumJobsFailed());
+ gen.writeStringField("flink-version", version);
+ if (commitID != null) {
--- End diff --
I think the commitID is `EnvironmentInformation.UNKNOWN` if its not
available?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-162333939 Tested the change on a cluster  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-161914994 Addressed null commit ids. If the commit id is not available, only version will be displayed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-161319181 +1 to what Stephan said. The commit id won't be available for releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-160655656 Here also, should we show the commit only for snapshot versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-160655246 Except for [one minor comment](https://github.com/apache/flink/pull/1418#issuecomment-160652388), the PR is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1422 [FLINK-3023][web-dashboard] Display version and commit information on Overview Page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sachingoel0101/flink 3023-web-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1422.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1422 commit ccd05eacc4fe78bf199a7195ded15ba75e0951a5 Author: Sachin Goel Date: 2015-11-28T09:26:16Z [FLINK-3023][web-dashboard] Display version and commit information on Overview Page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
