[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Github user tedyu closed the pull request at: https://github.com/apache/flink/pull/1474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1474#issuecomment-167405260 Thank you for the fix! This was merged, but not automatically closed. Could you close it manually? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1474#issuecomment-166934557 As some context: The class does not lock on all calls that can modify the state of the buffers (such as every `write()` call, for performance), so the locking removed in this PR becomes not effective anyways. +1, will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---