[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1610#issuecomment-182528014
  
Thanks for the review. I'll merge it then :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1610


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

[tillrohrmann]

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/1610#issuecomment-182319123
  
Failing tests are the yarn tests and thus most likely unrelated.

Changes look good to me :-) +1 for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3107] [runtime] Start checkpoint ID cou...

[uce]

GitHub user uce opened a pull request:

https://github.com/apache/flink/pull/1610

[FLINK-3107] [runtime] Start checkpoint ID counter with periodic scheduler

Problem: The job manager enables checkpoints during submission of streaming 
programs. This can lead to call to a call to 
`ZooKeeperCheckpointIDCounter.start()`, which communicates with ZooKeeper. This 
can block the job manager actor.

Solution: Start the counter in the `CheckpointCoordinatorDeActivator`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uce/flink 3107-counter_start

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1610


commit d70bc79e48dddb658c2240350837000ce9f1f0fe
Author: Ufuk Celebi 
Date:   2016-02-09T15:06:46Z

[FLINK-3107] [runtime] Start checkpoint ID counter with periodic scheduler

Problem: The job manager enables checkpoints during submission of streaming
programs. This can lead to call to a call to 
`ZooKeeperCheckpointIDCounter.start()`,
which communicates with ZooKeeper. This can block the job manager actor.

Solution: Start the counter in the `CheckpointCoordinatorDeActivator`.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---