[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1791#issuecomment-222113705
  
Closing this PR in favor of a new one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

[rmetzger]

Github user rmetzger closed the pull request at:

https://github.com/apache/flink/pull/1791


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

[rmetzger]

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1791#issuecomment-199192415
  
I rebased the change to the latest master.
I'm currently discussing with the author of the maven plugin if we can make 
it accept the removal of the `Key` interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

[rmetzger]

GitHub user rmetzger opened a pull request:

https://github.com/apache/flink/pull/1791

[FLINK-3129] Add japicmp-maven-plugin to ensure interface stability

Now that Flink 1.0.0 is available on MVN Central, we can ensure that a 
maven build does not break any public APIs.

Since the 1.0.0 release, there were already 2 API breaking changes:
- The public `ExecutionConfig.CONFIG_KEY` field was removed (I added it 
again)
- The `Key` interface was removed. (This breaks `public class *Value 
implements Key`)

I don't intend to merge all the revert commits included in this PR. I'd 
rather like to discuss how we handle the `Key` interface situation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmetzger/flink flink3129-second

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1791


commit 22047225dabfc4ee1c4679e0eba5fba82169d90c
Author: Robert Metzger 
Date:   2015-12-07T14:45:57Z

[FLINK-3129] Bring infrastructure for ensuring interface stability in place

commit 6b344c643a558eb4b21c03e05468ea789e41cb35
Author: Robert Metzger 
Date:   2016-03-12T17:25:08Z

Revert "remove javadoc referencs to key class"

This reverts commit e7718228813a5b993c631bf28ab0e67e0c94e1aa.

commit 3c9bb7def807cceebd92b58e7d2cada2980f5d90
Author: Robert Metzger 
Date:   2016-03-12T17:25:23Z

Revert "remove unused distributions"

This reverts commit 7fabf3f931aff047e9c0f035ed6928c8c49e08d7.

commit 7e786dfed6d61208f307abd689c8cf08cbbaee34
Author: Robert Metzger 
Date:   2016-03-12T17:25:30Z

Revert "NormalizableKey no longer extends Value"

This reverts commit da778675908eeacd550e7c97daa0842c40696496.

commit 23e5adf5b31d0c97a9088fa9a8e953d124c92139
Author: Robert Metzger 
Date:   2016-03-12T17:25:36Z

Revert "[FLINK-3169] Remove Key class"

This reverts commit f62cec89e11e28fd22eeb48505c0139684bdf00f.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---