[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-14 Thread fhueske
Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1606#issuecomment-183988942
  
Merging this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1606


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-12 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1606#issuecomment-183332749
  
Except for two questions, the PR looks good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-12 Thread fhueske
Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1606#issuecomment-183517665
  
Updated and rebased the PR. 
Any objections to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-11 Thread aljoscha
Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1606#issuecomment-182778504
  
I see. Might seem inconsistent, though. :smile: So maybe we should make all 
of them PublicEvolving.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-08 Thread fhueske
GitHub user fhueske opened a pull request:

https://github.com/apache/flink/pull/1606

[FLINK-3367] Add PublicEvolving and Internal annotations to classes in API 
modules

This PR includes the commit from #1599.

It adds annotations to all classes in the following modules:
- `flink-core`
- `flink-java`
- `flink-scala`
- `flink-streaming-java`
- `flink-streaming-scala`

By adding annotations to every class, annotation management becomes easier 
and we can enforce annotations for all new classes in our API modules.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fhueske/flink addPublicEvolvingInternal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1606


commit eb9bab1096125e49367c4780c25f0022334dd56f
Author: Fabian Hueske 
Date:   2016-02-08T13:14:01Z

[FLINK-3366] Rename @Experimental annotation to @PublicEvolving

commit 36e4239837e6123eafbbdb2d436f2140dfa49993
Author: Fabian Hueske 
Date:   2016-02-08T14:18:53Z

[FLINK-3367] Add PublicEvolving and Internal annotations to flink-java and 
flink-scala

commit a5b0fb952ce9f4d2f043a42c6cc3af9ee6bfefd0
Author: Fabian Hueske 
Date:   2016-02-08T15:57:08Z

[FLINK-3367] Add PublicEvolving and Internal annotations to flink-core

commit 5f4831d5321da22350912c834aad49742eb3bdde
Author: Fabian Hueske 
Date:   2016-02-08T16:56:14Z

[FLINK-3367] Add PublicEvolving and Internal annotations to 
flink-streaming-java and flink-streaming-scala




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---