[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1603#issuecomment-181813971 Exactly, the `AlignedTrigger` will have an `AlignedTriggerContext` without Key/Value state. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1603#issuecomment-181807335 You are not moving `TriggerContext` because it is specific to Trigger, correct? Otherwise it looks good to merge. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-3371] [api breaking] Move TriggerResult...
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1603 [FLINK-3371] [api breaking] Move TriggerResult and TriggerContext to dedicated classes **This change should go into 1.0, because it is API breaking** In order to prepare for adding aligned windows, this PR unnests some classes needed for aligned triggers. The functionality stays the same, only imports would need to be adjusted by users. You can merge this pull request into a Git repository by running: $ git pull https://github.com/StephanEwen/incubator-flink trigger_own_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1603 commit 3c05feef35384ac7ce9304ef461c7ef637fa3fe9 Author: Stephan Ewen Date: 2016-02-07T20:46:16Z Move TriggerResult and TriggerContext to dedicated classes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
