[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

[ggevay]

Github user ggevay commented on the pull request:

https://github.com/apache/flink/pull/1614#issuecomment-182025617
  
Shouldn't the current record remain valid if `hasNext()` returned true? I 
mean the user might be holding on to the object returned in `next`, and expect 
it to not be changed by a `hasNext` call:
```
T cur = it.next();
if(it.hasNext()) {
  // here, I would expect cur to not have changed since the next() call
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

[greghogan]

Github user greghogan commented on the pull request:

https://github.com/apache/flink/pull/1614#issuecomment-182035391
  
Ah, yes, now I see. I'll just burn this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

[greghogan]

GitHub user greghogan opened a pull request:

https://github.com/apache/flink/pull/1614

[FLINK-3382] Improve clarity of object reuse in 
ReusingMutableToRegularIteratorWrapper



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greghogan/flink 
3382_improve_clarity_of_object_reuse_in_ReusingMutableToRegularIteratorWrapper

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1614.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1614






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

[greghogan]

Github user greghogan closed the pull request at:

https://github.com/apache/flink/pull/1614


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---