[GitHub] flink pull request: [FLINK-3420] [api-breaking] Remove utility fun...

2016-02-17 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1648#issuecomment-185114983
  
Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3420] [api-breaking] Remove utility fun...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1648#issuecomment-185083603
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3420] [api-breaking] Remove utility fun...

2016-02-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1648


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3420] [api-breaking] Remove utility fun...

2016-02-16 Thread StephanEwen
GitHub user StephanEwen opened a pull request:

https://github.com/apache/flink/pull/1648

[FLINK-3420] [api-breaking] Remove utility functions from 
StreamExecutionEnvironment

This removes the functions  `readTextFileWithValue(...)` and 
`readFileOfPrimitives(...)` from `StreamExecutionEnvironment`.

These methods are highly specific for very niche cases of bounded data 
stream processing.
As such, the disadvantages (bloat and lock the API, lock the development 
into support) outweigh the benefit.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StephanEwen/incubator-flink 
remove_value_primitives

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1648


commit 152b1187ccfa343da9e2b299931f4d79404cb137
Author: Stephan Ewen 
Date:   2016-02-16T21:54:53Z

[FLINK-3420] [api-breaking] Remove utility functions 
'readTextFileWithValue' and 'readFileOfPrimitives' from 
StreamExecutionEnvironment

These methods are highly specific for very niche cases of bounded data 
stream processing.
As such, the disadvantages (bloat and lock the API, lock the development 
into support) outweigh the benefit.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---